Merge custom splits and nut 6 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@callebtc I had quite the confusion with the amounts, can you please take a look and tell if it's still readable for you? It seems to work, and the tests pass, but I think we might be switching things around unnecessarily |
gandlafbtc
requested review from
BilligsterUser and
callebtc
and removed request for
BilligsterUser
Closed
|
let's merge this, OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #77 and #85
Description
Merged PRs for deprecated amount field and custom split amounts.
Changes
PR Tasks
npm run test--> no failing unit testsnpm run format